Darshan N has posted comments on this change.

Change subject: packaging: setup: Hide irrelevant fields in configuration 
preview during setup
......................................................................


Patch Set 8:

(3 comments)

....................................................
File packaging/setup/ovirt_engine_setup/constants.py
Line 868
Line 869
Line 870
Line 871
Line 872
It is handled in domain_type.py .


Line 794:         summary=True,
Line 795:         description=_('NFS setup'),
Line 796:         postinstallfile=True,
Line 797:         summary_condition=(
Line 798:             lambda env: env[SystemEnv.NFS_CONFIG_ENABLED] != False
Done
Line 799:         ),
Line 800:     )
Line 801:     def NFS_CONFIG_ENABLED(self):
Line 802:         return 'OVESETUP_SYSTEM/nfsConfigEnabled'


....................................................
File packaging/setup/plugins/ovirt-engine-setup/config/domain_type.py
Line 99:         ),
Line 100:         condition=lambda self: (
Line 101:             self._enabled and
Line 102:             self.environment[osetupcons.ConfigEnv.APPLICATION_MODE] 
!= 'gluster'
Line 103:         ),
Done
Line 104:     )
Line 105:     def _misc(self):
Line 106:         self.environment[osetupcons.DBEnv.STATEMENT].execute(
Line 107:             statement="""


-- 
To view, visit http://gerrit.ovirt.org/20955
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e4b3fffd37a62d9fc551dff178d5662d610ddd4
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Darshan N <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Aravinda VK <[email protected]>
Gerrit-Reviewer: Darshan N <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to