Michael Pasternak has posted comments on this change. Change subject: cli: mismatch between restore snapshot syntax and auto completion(#1027298) ......................................................................
Patch Set 2: Code-Review-1 (1 comment) .................................................... File src/ovirtcli/shell/engineshell.py Line 167: s = self.__input_buffer Line 168: self.__input_buffer = '' Line 169: self.__set_prompt(mode=PromptMode.Original) Line 170: if command == 'action': Line 171: s = self.__reformat_command(s) ravi, i'd expect this happen at auto-completion (after action been chosen) and not at during invocation because: 1. the command actually used is incorrect and breaking the command syntax [1] (remember it won't always happen only when you need the parent to understand what actions are available) 2. if one will put it a side and use in script, it won't work. 3. EngineShell should be opaque to the "command pattern", it only addressing shell related issues and invoking the commands. [1] action <type> <id> <action> [parent identifiers] [command options] Line 172: return cmd.Cmd.onecmd(self, s) Line 173: finally: Line 174: if self.context.status == \ Line 175: self.context.SYNTAX_ERROR \ -- To view, visit http://gerrit.ovirt.org/21051 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I985d9f084ca3009ba165ca43a5ef01718b7b06e6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
