Alon Bar-Lev has uploaded a new change for review. Change subject: utils: pki-resources: cleanup: add final to all members ......................................................................
utils: pki-resources: cleanup: add final to all members Change-Id: I4c7fa841aefe0f6c2c482e7124529e13b396e666 Signed-off-by: Alon Bar-Lev <[email protected]> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/PKIResources.java 1 file changed, 6 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/91/21191/1 diff --git a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/PKIResources.java b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/PKIResources.java index 54ef7e0..ef7acdd 100644 --- a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/PKIResources.java +++ b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/PKIResources.java @@ -56,8 +56,8 @@ X509_PEM("application/x-x509-cert", formatPEM), OPENSSH_PUBKEY("text/plain", formatOpenSSH); - private String contentType; - private IFormatter formatter; + private final String contentType; + private final IFormatter formatter; private Format(String contentType, IFormatter formatter) { this.contentType = contentType; @@ -81,9 +81,10 @@ CACertificate(EngineLocalConfig.getInstance().getPKICACert(), Format.X509_PEM_CA, null), EngineCertificate(EngineLocalConfig.getInstance().getPKIEngineCert(), Format.X509_PEM, "ovirt-engine"); - private Certificate cert; - private Format defaultFormat; - private String defaultAlias; + private final Certificate cert; + private final Format defaultFormat; + private final String defaultAlias; + private Resource(File cert, Format defaultFormat, String defaultAlias) { try (InputStream in = new FileInputStream(cert)) { this.cert = CertificateFactory.getInstance("X.509").generateCertificate(in); -- To view, visit http://gerrit.ovirt.org/21191 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4c7fa841aefe0f6c2c482e7124529e13b396e666 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
