Eli Mesika has posted comments on this change.
Change subject: core: adding backup and restore scripts to dbscripts
......................................................................
Patch Set 2: (2 inline comments)
about your other comments :
>>another thing that I just thought of - the file name you >>produce will look
>>like this, e.g.: >>engineMon_Apr_23_16:16:32_IDT_2012.sql
Done
>>I think adding an _ after the database's name will make it >>more readable.
>>2. Perhaps a different date format, without >>the ":" will cause less
>>problems when porting in the future.
This is not a fixed format, it uses the <date> command that will create the
date according to the current locale settings
....................................................
File backend/manager/dbscripts/backup.sh
Line 24: printf "\t-d DATABASE - The database name
(def. ${DATABASE})\n"
Nice catch , done
setting the user param as mandatory since it has an empty default
....................................................
File backend/manager/dbscripts/restore.sh
Line 23: printf "\t-p PORT - The database port for the database
(def. ${PORT})\n"
same solution
--
To view, visit http://gerrit.ovirt.org/3523
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I57ac38ee8d412fa86c8a35b03caf29ff452848b0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
