Daniel Erez has posted comments on this change.

Change subject: webadmin: VM GuideMe - update dialog on attach disk
......................................................................


Patch Set 1:

(1 comment)

....................................................
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGuideModel.java
Line 47: 
Line 48:     public void updateOptions(boolean containsDisks) {
Line 49:         getCompulsoryActions().clear();
Line 50:         getOptionalActions().clear();
Line 51:         startProgress(null);
Right, I haven't added it for the progress indication but rather for raising an 
event to GuidePopupView. Otherwise, the guide me popup won't refresh - as the 
logic is on "Progress" PropertyChangedEvent.
Line 52: 
Line 53:         // Add disk action.
Line 54:         UICommand addDiskAction = new UICommand("AddDisk", this); 
//$NON-NLS-1$
Line 55: 


-- 
To view, visit http://gerrit.ovirt.org/21090
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I21f7f8b7cd0733b2b2fc06cbe7cc39a9a42b755e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to