Liron Ar has posted comments on this change.
Change subject: core: Host shouldn't move to UP if it's already connected to
other pool
......................................................................
Patch Set 2:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java
Line 221:
getStorageDomainDAO().getStorageDomainByTypeAndPool(storagePoolId,
StorageDomainType.Master);
Line 222: boolean masterDomainInactiveOrUnknown =
masterDomain.getStatus() == StorageDomainStatus.InActive
Line 223: || masterDomain.getStatus() ==
StorageDomainStatus.Unknown;
Line 224:
Line 225: VDSReturnValue returnValue =
ResourceManager.getInstance().runVdsCommand(VDSCommandType.ConnectStoragePool,
I'm using it because currently ConnectStoragePool overrides
proceedProxyReturnValue and has different behavior for different return values
received from vdsm (which was added by purpose according to the comment there)
I want to to unify this behavior/return values in a separate patch, at the
moment the 'common' between the different return values is that getSucceeded()
will be false.
I didn't want to add more cases to that switch case (add this code as well).
regardless, I'm having general debates about the usage of the "Frontend"
resource manager current api, the exception thrown there purpose is to bll
commands that doesn't catch it, if we do catch it always and inspect the return
value within the command..i don't think that we need it to be thrown at all in
those cases.
Line 226: new
ConnectStoragePoolVDSCommandParameters(vds.getId(), storagePoolId,
Line 227: vds.getVdsSpmId(), masterDomain.getId(),
Line 228: storagePool.getmaster_domain_version()));
Line 229: if (!returnValue.getSucceeded()) {
--
To view, visit http://gerrit.ovirt.org/21095
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd3d8268516b010f7831b59bbc6331cfd70efec1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
