Omer Frenkel has posted comments on this change. Change subject: core: taskcleaner.sh '-l' option does not prod... ......................................................................
Patch Set 1: Code-Review+2 (1 comment) .................................................... Commit Message Line 3: AuthorDate: 2013-11-13 13:43:16 +0200 Line 4: Commit: Eli Mesika <[email protected]> Line 5: CommitDate: 2013-11-13 13:43:19 +0200 Line 6: Line 7: core: taskcleaner.sh '-l' option does not prod... this may be just a personal preference, but i think i would be better to have a meaningful commit title, so it would imply what the patch is doing, and not part of the bug subject which doesn't say anything about this patch. Line 8: Line 9: Adding -L to the psql call to log command and its result. Line 10: Line 11: Change-Id: Iee255ff5f929d795790088d5cf3475db0b81e04a -- To view, visit http://gerrit.ovirt.org/21215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iee255ff5f929d795790088d5cf3475db0b81e04a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
