Allon Mureinik has posted comments on this change. Change subject: engine: Remove AddStorageDomainCommand.checkExistingStorageDomain ......................................................................
Patch Set 1: (2 comments) .................................................... Commit Message Line 3: AuthorDate: 2013-11-17 08:03:11 +0200 Line 4: Commit: Sergey Gotliv <[email protected]> Line 5: CommitDate: 2013-11-17 08:10:38 +0200 Line 6: Line 7: engine: Remove AddStorageDomainCommand.checkExistingStorageDomain This is not what the path is doing. As you explain in the commit message, this method is not REMOVED, but simply MOVED. Line 8: Line 9: There is no reason to keep this method in the base class Line 10: AddStorageDomainCommand just because it used by one of it's successors. Line 11: Line 13: Line 14: The method is modified on the way to its correct location: Line 15: 1. Use regular imports instead of inline. Line 16: 2. Use quick return in case of failure. Line 17: 3. Use shorter runVdsCommand. I'd do all of these in a separate patch, to make reviewing easier. Line 18: Line 19: Change-Id: I2002f942d32aacf7bbcaa8b6caef3bb744d2dd48 -- To view, visit http://gerrit.ovirt.org/21322 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2002f942d32aacf7bbcaa8b6caef3bb744d2dd48 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
