Juan Hernandez has posted comments on this change. Change subject: Add missign storage_format_type arg to Updatestorage_domain_static ......................................................................
Patch Set 6: (2 inline comments) This change looks ok, but there is a lot of white space noise. Can you please try to avoid changing white space outside of the procedure you are modifying? It really complicates the review. In addition this change is not standalone. I mean, changing only the procedure will break the backend, till the other backend changes are applied. I think that you should merge both changes. .................................................... File backend/manager/dbscripts/storages_sp.sql Line 45: spm_vds_id = v_spm_vds_id,compatibility_version = v_compatibility_version, If you avoid changing spaces here (even it is the right thing to do) it is easier to review. Line 273: LANGUAGE plpgsql; This procedure is the only real change, as far as I can tell. -- To view, visit http://gerrit.ovirt.org/2440 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifc51ee4a527339e223cf852c85d144f63b60fe09 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
