Allon Mureinik has posted comments on this change.
Change subject: engine: Simplify AddExistingFileStorageDomainCommand
......................................................................
Patch Set 2:
(3 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingFileStorageDomainCommand.java
Line 63: return
failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_IMPORT_DATA_DOMAIN_PROHIBITED);
Line 64: }
Line 65:
Line 66: if
(DbFacade.getInstance().getStorageDomainStaticDao().get(getStorageDomain().getId())
!= null) {
Line 67: return
failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_STORAGE_DOMAIN_NOT_EXIST);
This seems like a typo, please remove it
Line 68: }
Line 69:
Line 70: List<Guid> storageIds = (ArrayList<Guid>)
runVdsCommand(VDSCommandType.HSMGetStorageDomainsList,
Line 71: new
HSMGetStorageDomainsListVDSCommandParameters(getVdsId(), Guid.Empty,
getStorageDomain()
Line 67: return
failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_STORAGE_DOMAIN_NOT_EXIST);
Line 68: }
Line 69:
Line 70: List<Guid> storageIds = (ArrayList<Guid>)
runVdsCommand(VDSCommandType.HSMGetStorageDomainsList,
Line 71: new
HSMGetStorageDomainsListVDSCommandParameters(getVdsId(), Guid.Empty,
getStorageDomain()
why is this formatting relevant to this patch?
Line 72: .getStorageType(),
getStorageDomain().getStorageDomainType(), "")
Line 73: ).getReturnValue();
Line 74:
Line 75: if (!storageIds.contains(getStorageDomain().getId())) {
Line 72: .getStorageType(),
getStorageDomain().getStorageDomainType(), "")
Line 73: ).getReturnValue();
Line 74:
Line 75: if (!storageIds.contains(getStorageDomain().getId())) {
Line 76: return
failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_STORAGE_DOMAIN_ALREADY_EXIST);
why is this formatting relevant to this patch?
Line 77: }
Line 78:
Line 79: Pair<StorageDomainStatic, SANState> domainFromIrs =
(Pair<StorageDomainStatic, SANState>) runVdsCommand(
Line 80: VDSCommandType.HSMGetStorageDomainInfo,
--
To view, visit http://gerrit.ovirt.org/21323
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I21960f64d45c01a65978a44d5874b8c94dfb9420
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
