Allon Mureinik has uploaded a new change for review. Change subject: core: char literals in Version ......................................................................
core: char literals in Version Use char literals instead of string literals in the Version class wherever possible to (slightly) improve performance. Change-Id: I57b19b57f405cf83b219715f111f5167a4ffa3fb Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Version.java 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/99/21399/1 diff --git a/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Version.java b/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Version.java index 299d6bf..7899a0f 100644 --- a/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Version.java +++ b/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Version.java @@ -67,7 +67,7 @@ private static void appendVersionComponent(StringBuilder val, int versionNumber) { if (versionNumber > -1) { if (val.length() != 0) { - val.append("."); + val.append('.'); } val.append(versionNumber); } @@ -95,11 +95,11 @@ StringBuilder sb = new StringBuilder(); switch (i) { case (4): - sb.append(".").append(revision); + sb.append('.').append(revision); case (3): - sb.insert(0, build).insert(0, "."); + sb.insert(0, build).insert(0, '.'); case (2): - sb.insert(0, minor).insert(0, "."); + sb.insert(0, minor).insert(0, '.'); case (1): sb.insert(0, major); } -- To view, visit http://gerrit.ovirt.org/21399 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I57b19b57f405cf83b219715f111f5167a4ffa3fb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
