Yair Zaslavsky has posted comments on this change.
Change subject: core: Change code to use ImageDao
......................................................................
Patch Set 3: (5 inline comments)
Really minor comments
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java
Line 125: protected ImageDao getImageDao() {
Is this the only class hierarchy where needed?
No need to do that in one of the ancestors of this class?
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java
Line 73: protected ImageDao getImageDao() {
See the question I just asked in the previous file
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateImageTemplateCommand.java
Line 137:
DbFacade.getInstance().getImageDao().remove(getDestinationImageId());
If you already changed that, why not getImageDao().remove
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateSnapshotCommand.java
Line 152:
DbFacade.getInstance().getImageDao().update(getDiskImage().getImage());
Same question as before
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
Line 272: DbFacade.getInstance().getImageDao().save(image.getImage());
If you decide to change this to getDiskDao(), just go all over the code, I will
not write this comment again :)
--
To view, visit http://gerrit.ovirt.org/3835
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4769164bf1d7f5693783457f6916035c2b2adfe
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
