Tal Nisan has posted comments on this change.
Change subject: core: Rename members in XML-handling classes
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/XmlUtils.java
Line 71: // {
Line 72: // XmlNode node = doc.SelectSingleNode(xPath);
Line 73: // if (node != null)
Line 74: // {
Line 75: // node.attributes[attribute].setValue(value);
Yeah I think you should remove them, maybe in a different patch though
Line 76: // }
Line 77: // }
Line 78: // catch (RuntimeException ex)
Line 79: // {
--
To view, visit http://gerrit.ovirt.org/21401
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c42b439c6482650dadb40d08ab5fbf737e0fbdf
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
