Eli Mesika has posted comments on this change.

Change subject: backend: AuditLogDirector - replace <UNKNOWN> string
......................................................................


Patch Set 1:

(1 comment)

....................................................
File 
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
Line 26:     private static final Map<AuditLogType, String> messages = new 
EnumMap<AuditLogType, String>(AuditLogType.class);
Line 27:     private static final Map<AuditLogType, AuditLogSeverity> 
severities =
Line 28:             new EnumMap<AuditLogType, 
AuditLogSeverity>(AuditLogType.class);
Line 29:     private static final Pattern pattern = 
Pattern.compile("\\$\\{\\w*\\}"); // match ${<alphanumeric>...}
Line 30:     static final String UNKNOWN_VARIABLE_VALUE = "non interactive 
user";
Shouldn't that be with capital N @ start ???
Line 31:     private static final String APP_ERRORS_MESSAGES_FILE_NAME = 
"bundles/AuditLogMessages";
Line 32: 
Line 33:     static {
Line 34:         initMessages();


-- 
To view, visit http://gerrit.ovirt.org/19627
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I81c2cab403ec045a617ed1190df716c1620338a8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to