Allon Mureinik has posted comments on this change.
Change subject: core: LSM - lock changes, added support for disk snapshot
scenarios
......................................................................
Patch Set 5:
(2 comments)
Seems to make sense.
Daniel? Arik?
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/DiskImagesValidatorTest.java
Line 75
Line 76
Line 77
Line 78
Line 79
Unrelated to the patch, please remove
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImagesActionsParametersBase.java
Line 99: public void setImportEntity(boolean importEntity) {
Line 100: this.importEntity = importEntity;
Line 101: }
Line 102:
Line 103: public boolean isShouldLeaveLocked() {
"isShould" is not English. Just use should
Line 104: return shouldLeaveLocked;
Line 105: }
Line 106:
Line 107: public void setShouldLeaveLocked(boolean shouldLeaveLocked) {
--
To view, visit http://gerrit.ovirt.org/20847
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c7cb49ff37f28d0b3ab0df9f4ee1f3082aba018
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
