Kanagaraj M has posted comments on this change.

Change subject: webadmin: fix sub-tabs loading issue in volumes tab
......................................................................


Patch Set 2:

(2 comments)

....................................................
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickListModel.java
Line 269:         if (getEntity() != null) {
Line 270:             super.search();
Line 271:         }
Line 272:     }
Line 273: 
no need to override search()
Line 274:     @Override
Line 275:     protected void syncSearch() {
Line 276:         if (getEntity() == null) {
Line 277:             return;


....................................................
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeParameterListModel.java
Line 405:     public void search() {
Line 406:         if (getEntity() != null) {
Line 407:             super.search();
Line 408:         }
Line 409:     }
same here
Line 410: 
Line 411:     @Override
Line 412:     protected void syncSearch()
Line 413:     {


-- 
To view, visit http://gerrit.ovirt.org/21449
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1051df9da2233723894a931c981688dfab9478c3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ramesh N <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Ramesh N <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to