Juan Hernandez has posted comments on this change. Change subject: sdk: Add debug logging of the HTTP messages ......................................................................
Patch Set 1: Verified (2 inline comments) .................................................... File src/ovirtsdk/infrastructure/proxy.py Line 82: if response.status < 400: There is always a response body (might be empty) unless the server side HTTP implementation is broken or there is a communications error. Redirection in particular should be checked and handled, but I think that not as part of this change. Line 86: except socket.error, e: I take note of that, but prefer not to include a fix for that in this change. Speaking broadly about logging: it is true that usually you don't want logging failures to break the real code. In this particular case that is quite unlikely as the logging logic only runs when debug is enabled and it is simple. I mean, I prefer an unlikely failure of the real code due to logging than a likely failure of the real code that leaves no trace. -- To view, visit http://gerrit.ovirt.org/3934 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82d9101ebae8197df6554992d583faacf6bc2a9d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Alex Jia <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
