Tal Nisan has posted comments on this change. Change subject: core: SnapshotManager - disk devices might not represent engine disks ......................................................................
Patch Set 2: (1 comment) .................................................... Commit Message Line 16: remove it (as being done for disks that aren't snappable/snapshot Line 17: disks). Line 18: Line 19: Note - This method could be refactored to load the vm disks Line 20: directly instead of the devices and then the disks. In this patch i Fix the part starts with "In this patch patch i", it makes no sense :) Line 21: the null check would be added, while further refactor would be done in Line 22: follow up change. Line 23: Line 24: Change-Id: Ie38c39c0f0409988a73610fe1dfb9a22afee5553 -- To view, visit http://gerrit.ovirt.org/21580 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie38c39c0f0409988a73610fe1dfb9a22afee5553 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
