Juan Hernandez has posted comments on this change.
Change subject: core: Simple parameters for add and remove users
......................................................................
Patch Set 5:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUserCommand.java
Line 15: import org.ovirt.engine.core.common.errors.VdcBllMessages;
Line 16: import org.ovirt.engine.core.compat.Guid;
Line 17: import org.ovirt.engine.core.dao.DbUserDAO;
Line 18:
Line 19: public class AddUserCommand<T extends DirectoryIdParameters> extends
CommandBase<T> {
This command is used from the RESTAPI when and from the GUI to add users. I
agree that it would be more performant to add several of them with one command,
but that is way out of the scope of this patch series.
Line 20:
Line 21: // We save a reference to the directory user to avoid looking it
up once
Line 22: // when checking the conditions and another time when actuall
adding
Line 23: // the user to the database:
--
To view, visit http://gerrit.ovirt.org/19480
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c37a686b28f38ce47e9a7d590e3f706164dc09c
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
