Alon Bar-Lev has posted comments on this change. Change subject: [db] Adding support for user types cleanup ......................................................................
Patch Set 6: (2 comments) verified setup using downstream upgrade (3.2->master)? .................................................... File packaging/setup/ovirt_engine_setup/database.py Line 357: pg_proc inner join pg_namespace ns on ( Line 358: pg_proc.pronamespace=ns.oid Line 359: ) Line 360: where Line 361: ns.nspname = 'public' why have you indented the ns one char? Line 362: union Line 363: select Line 364: 'drop type if exists ' || Line 365: user_defined_type_name || ' ' || Line 358: pg_proc.pronamespace=ns.oid Line 359: ) Line 360: where Line 361: ns.nspname = 'public' Line 362: union why have you indented the union into the where? Line 363: select Line 364: 'drop type if exists ' || Line 365: user_defined_type_name || ' ' || Line 366: 'cascade;' -- To view, visit http://gerrit.ovirt.org/20498 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a7d5a644895be7374febec081e4931be1902962 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
