Omer Frenkel has posted comments on this change.
Change subject: core: rename Images to lowercase in RemoveAllVmImagesParameters
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveAllVmImagesParameters.java
Line 4: import org.ovirt.engine.core.compat.Guid;
Line 5:
Line 6: public class RemoveAllVmImagesParameters extends
VmOperationParameterBase implements java.io.Serializable {
Line 7: private static final long serialVersionUID = 7211692656127711421L;
Line 8: public java.util.List<DiskImage> images;
i guess the right fix would be to make it also private and add a public
getImages() method
Line 9:
Line 10: public RemoveAllVmImagesParameters(Guid vmId,
java.util.List<DiskImage> images) {
Line 11: super(vmId);
Line 12: this.images = images;
--
To view, visit http://gerrit.ovirt.org/21619
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I28dfd311df5689160cc5fb533b7ce6248eca4cb9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
