Liron Ar has posted comments on this change.
Change subject: core,webadmin: add isVm and isTemplate methods to VmEntityType
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
General - what about floating disks? no NPEs?
marking -1 just till that's answered.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java
Line 82: canRemoveDiskBasedOnStorageTypeCheck();
Line 83: }
Line 84:
Line 85: private boolean validateAllVmsForDiskAreDown() {
Line 86: if (getDisk().getVmEntityType().isVmType()) {
what about floating disks?
Line 87: for (VM vm : getVmsForDiskId()) {
Line 88: if (vm.getStatus() != VMStatus.Down) {
Line 89: VmDevice vmDevice = getVmDeviceDAO().get(new
VmDeviceId(getDisk().getId(), vm.getId()));
Line 90: if (vmDevice.getIsPlugged()) {
--
To view, visit http://gerrit.ovirt.org/21598
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6fc92031ab0afd08ab309a8ef6fd71a3fddb2204
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Leonardo Bianconi <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
