Alissa Bonas has uploaded a new change for review. Change subject: core: rename method to lowercase in LdapBrokerCommandBase ......................................................................
core: rename method to lowercase in LdapBrokerCommandBase Solves a findbug warning. Change-Id: I166f7cb1ac05c8fff9712059b96489a53152a934 Signed-off-by: Alissa Bonas <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapAuthenticateUserCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapBrokerCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapGetAdUserByUserIdCommand.java 3 files changed, 9 insertions(+), 9 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/65/21665/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapAuthenticateUserCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapAuthenticateUserCommand.java index bd250d9..d86bcfe 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapAuthenticateUserCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapAuthenticateUserCommand.java @@ -59,7 +59,7 @@ if (generator.getHasValues()) { List<LdapQueryData> partialQueries = generator.getLdapQueriesData(); for (LdapQueryData currQueryData : partialQueries) { - PopulateGroup(currQueryData, + populateGroup(currQueryData, getAuthenticationDomain(), user.getGroups(), getLoginName(), diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapBrokerCommandBase.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapBrokerCommandBase.java index 916169b..3030193 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapBrokerCommandBase.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapBrokerCommandBase.java @@ -112,11 +112,11 @@ return user; } - protected void PopulateGroup(LdapQueryData queryData, - String domain, - java.util.Map<String, LdapGroup> groupsDict, - String loginName, - String password) { + protected void populateGroup(LdapQueryData queryData, + String domain, + java.util.Map<String, LdapGroup> groupsDict, + String loginName, + String password) { try { GroupsDNQueryGenerator generator = new GroupsDNQueryGenerator(); List<GroupSearchResult> searchResultCollection = @@ -130,11 +130,11 @@ if (generator.getHasValues()) { List<LdapQueryData> partialQueries = generator.getLdapQueriesData(); for (LdapQueryData partialQuery : partialQueries) { - PopulateGroup(partialQuery, domain, groupsDict, loginName, password); + populateGroup(partialQuery, domain, groupsDict, loginName, password); } } } catch (RuntimeException e) { - log.infoFormat("PopulateGroup failed. Exception: {0}", e); + log.infoFormat("populateGroup failed. Exception: {0}", e); } } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapGetAdUserByUserIdCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapGetAdUserByUserIdCommand.java index fee095e..fba5a76 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapGetAdUserByUserIdCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapGetAdUserByUserIdCommand.java @@ -34,7 +34,7 @@ GroupsDNQueryGenerator generator = createGroupsGeneratorForUser(user); List<LdapQueryData> partialQueries = generator.getLdapQueriesData(); for (LdapQueryData partialQuery : partialQueries) { - PopulateGroup(partialQuery, getDomain(), user.getGroups(), getLoginName(), getPassword()); + populateGroup(partialQuery, getDomain(), user.getGroups(), getLoginName(), getPassword()); } } setReturnValue(user); -- To view, visit http://gerrit.ovirt.org/21665 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I166f7cb1ac05c8fff9712059b96489a53152a934 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
