Eli Mesika has posted comments on this change.
Change subject: [WIP] engine : 998980 Generic mechanism for update diffs in
audit
......................................................................
Patch Set 3:
(2 comments)
Piotr , lets advance that, we have here a working method that is a significant
improvement of what we have now in hande.
I think that the enemy of GOOD is EXCELLENT and we may do that in 2 phases
while the first still uses the original BLL entity attributes names
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
Line 833:
Line 834: //mom policies
Line 835: USER_UPDATED_MOM_POLICIES(10200),
Line 836: USER_FAILED_TO_UPDATE_MOM_POLICIES(10201),
Line 837: UPDATE_PARAMS(11100)
Agree
Line 838: ;
Line 839:
Line 840: private int intValue;
Line 841: // indicates time interval in seconds on which identical events
from same instance are supressed.
....................................................
File
backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
Line 713: USER_FAILED_TO_UPDATE_MOM_POLICIES=Mom policy could not be updated on
host ${VdsName}.
Line 714: DISK_ALIGNMENT_SCAN_START=Starting alignment scan of disk
'${DiskAlias}'.
Line 715: DISK_ALIGNMENT_SCAN_FAILURE=Alignment scan of disk '${DiskAlias}'
failed.
Line 716: DISK_ALIGNMENT_SCAN_SUCCESS=Alignment scan of disk '${DiskAlias}' is
complete.
Line 717: UPDATE_PARAMS= Update parameters are ${update_params}.
Maybe it better to have the space on the 1st part and have this one aligned
with all others for clarity
--
To view, visit http://gerrit.ovirt.org/20265
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3362f9bfffe921df44103239ece8348001feca5
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Piotr Kliczewski <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
