Alissa Bonas has uploaded a new change for review. Change subject: frontend: stop using keyset in GWTRPCCommunicationProvider ......................................................................
frontend: stop using keyset in GWTRPCCommunicationProvider Change-Id: I49ad8873174ecbe1c215749741598cf6c1e9e22e Signed-off-by: Alissa Bonas <[email protected]> --- M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/communication/GWTRPCCommunicationProvider.java 1 file changed, 6 insertions(+), 6 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/97/21697/1 diff --git a/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/communication/GWTRPCCommunicationProvider.java b/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/communication/GWTRPCCommunicationProvider.java index b1b132c..ce740e2 100644 --- a/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/communication/GWTRPCCommunicationProvider.java +++ b/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/communication/GWTRPCCommunicationProvider.java @@ -212,21 +212,21 @@ * type */ private void transmitMultipleActions(final Map<VdcActionType, List<VdcOperation<?, ?>>> actions) { - for (final VdcActionType actionType: actions.keySet()) { + for (final Map.Entry<VdcActionType, List<VdcOperation<?, ?>>> actionEntry: actions.entrySet()) { List<VdcActionParametersBase> parameters = new ArrayList<VdcActionParametersBase>(); - final List<VdcOperation<?, ?>> allActionOperations = actions.get(actionType); + final List<VdcOperation<?, ?>> allActionOperations = actionEntry.getValue(); for (VdcOperation<?, ?> operation: allActionOperations) { parameters.add((VdcActionParametersBase) operation.getParameter()); } if (parameters.size() > 1 || (allActionOperations.size() == 1 && allActionOperations.get(0).getCallback() instanceof VdcOperationCallbackList)) { - getService().RunMultipleActions(actionType, (ArrayList<VdcActionParametersBase>) parameters, false, + getService().RunMultipleActions(actionEntry.getKey(), (ArrayList<VdcActionParametersBase>) parameters, false, new AsyncCallback<ArrayList<VdcReturnValueBase>>() { @Override public void onFailure(final Throwable exception) { Map<VdcOperationCallback<?, ?>, List<VdcOperation<?, ?>>> callbackMap = - getCallbackMap(actions.get(actionType)); + getCallbackMap(actionEntry.getValue()); for (Map.Entry<VdcOperationCallback<?, ?>, List<VdcOperation<?, ?>>> callbackEntry: callbackMap.entrySet()) { if (callbackEntry.getKey() instanceof VdcOperationCallbackList) { ((VdcOperationCallbackList) callbackEntry.getKey()).onFailure(callbackEntry.getValue(), exception); @@ -240,7 +240,7 @@ @Override public void onSuccess(final ArrayList<VdcReturnValueBase> result) { Map<VdcOperationCallback<?, ?>, List<VdcOperation<?, ?>>> callbackMap = - getCallbackMap(actions.get(actionType)); + getCallbackMap(actionEntry.getValue()); for (Map.Entry<VdcOperationCallback<?, ?>, List<VdcOperation<?, ?>>> callbackEntry: callbackMap.entrySet()) { List<VdcReturnValueBase> actionResult = (List<VdcReturnValueBase>) getOperationResult(callbackEntry.getValue(), allActionOperations, result); @@ -256,7 +256,7 @@ }); } else { - transmitOperation(actions.get(actionType).get(0)); + transmitOperation(actionEntry.getValue().get(0)); } } } -- To view, visit http://gerrit.ovirt.org/21697 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I49ad8873174ecbe1c215749741598cf6c1e9e22e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
