Moti Asayag has posted comments on this change.
Change subject: core: runVmOnce failed only from rest api
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java
Line 253: private static boolean isBootable(VmDevice device) {
please revert the operands to use the enum first:
return (VmDeviceType.DISK.getName().equals(device.getType()) ||
VmDeviceType.INTERFACE.getName().equals(device.getType()));
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
Line 355: struct.add(VdsProperties.BootOrder,
String.valueOf(vmDevice.getBootOrder()));
please keep indentation.
--
To view, visit http://gerrit.ovirt.org/3965
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I43dbc8083dc6d804e89235df4058be3c8a7d5638
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
