Martin Sivák has uploaded a new change for review. Change subject: Reorder limit checks in grow quest ......................................................................
Reorder limit checks in grow quest balloon_min is a computed value that can (and will) go over balloon_max. When the controller tries to use it VDSM reports exception. Reorder the checks so the balloon_max constant check is the latest one to limit the value. Change-Id: I3e542b5d1c165e32b8555e5510660ced136c6ab9 Signed-off-by: Martin Sivak <[email protected]> --- M doc/balloon.rules 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/mom refs/changes/26/21726/1 diff --git a/doc/balloon.rules b/doc/balloon.rules index 52570c3..31d3099 100644 --- a/doc/balloon.rules +++ b/doc/balloon.rules @@ -77,10 +77,10 @@ # Determine the new target for the BalloonController. Only set # if the value is a large enough for the change to be worth it. - (if (> balloon_size guest.balloon_max) - (set balloon_size guest.balloon_max) 0) (if (< balloon_size balloon_min) (set balloon_size balloon_min) 0) + (if (> balloon_size guest.balloon_max) + (set balloon_size guest.balloon_max) 0) (if (change_big_enough guest balloon_size) (guest.Control "balloon_target" balloon_size) 0) } 0) -- To view, visit http://gerrit.ovirt.org/21726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3e542b5d1c165e32b8555e5510660ced136c6ab9 Gerrit-PatchSet: 1 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Martin Sivák <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
