Daniel Erez has posted comments on this change. Change subject: webadmin: Gluster Messages ......................................................................
Patch Set 2: - Messages keys should not contain dot characters (e.g. VALIDATION.GLUSTER.VOLUME.ID.NOT_NULL should be replaced with VALIDATION_GLUSTER_VOLUME_ID_NOT_NULL) - These messgaes keys should be added also to AppErrors.java (e.g. String VALIDATION_GLUSTER_VOLUME_ID_NOT_NULL();) - UserPortal's properties files should be updated as well: -- /frontend/webadmin/modules/userportal/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties -- /frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties -- To view, visit http://gerrit.ovirt.org/3904 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25bedd1c78d9a3b2d2de5e2ac2a2d02f543c0b8f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Raksha Rao <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Raksha Rao <[email protected]> Gerrit-Reviewer: Shireesh Anjal <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
