Frank Kobzik has uploaded a new change for review. Change subject: core: Add TODO note about deprecated VM state ......................................................................
core: Add TODO note about deprecated VM state This patch adds a TODO comment that prevents us from forgetting to delete deprecated states sent by VDSM. We should delete them as soon as 3.3 is no longer supported. Change-Id: I3a5cce6b5337d4de3bf84092429f19fce5e0f574 Signed-off-by: Frantisek Kobzik <[email protected]> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/25/21825/1 diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java index 67e03a0..7f3b79c 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java @@ -901,6 +901,10 @@ private static VMStatus convertToVmStatus(String statusName) { VMStatus status = VMStatus.Unassigned; + + // TODO: The following condition should deleted as soon as we drop compatibility with 3.3 since "Running" state + // will be replaced "Up" state and "Unknown" will exist no more. The "Up" state will be processed by + // EnumUtils as other states below. if ("Running".equals(statusName) || "Unknown".equals(statusName)) { status = VMStatus.Up; } -- To view, visit http://gerrit.ovirt.org/21825 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3a5cce6b5337d4de3bf84092429f19fce5e0f574 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
