Tal Nisan has posted comments on this change.
Change subject: core: Plug disk to VM when adding a new disk
......................................................................
Patch Set 1:
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
Line 402: getVmId()),
Line 403: VmDeviceGeneralType.DISK,
Line 404: VmDeviceType.DISK,
Line 405: null,
Line 406: getVm().getStatus() == VMStatus.Down &&
getParameters().getPlugDiskToVm(),
Yes cause in that case the plugging will be handled only in the endSuccessfully
phase, this parameter was added to override the existing situation when you add
a disk and by default it's plugged if the VM is down
Line 407:
Boolean.TRUE.equals(getParameters().getDiskInfo().getReadOnly()),
Line 408: null));
Line 409: getCompensationContext().stateChanged();
Line 410: }
Line 546: super.endSuccessfully();
Line 547: }
Line 548:
Line 549: private void plugDiskToVmIfNeeded() {
Line 550: if (getVm() != null && getParameters().getPlugDiskToVm() &&
getVm().getStatus() != VMStatus.Down) {
I'm not sure I'd like to count on the plug command to handle it, this is this
command's responsibility to take care of the whole flow, vm is down? Plug it
upon creation, not down? plug it in the end phase and of course everything with
regards to the PlugDiskToVm option
Line 551: HotPlugDiskToVmParameters params = new
HotPlugDiskToVmParameters(getVmId(), getParameters().getDiskInfo().getId());
Line 552:
Backend.getInstance().runInternalAction(VdcActionType.HotPlugDiskToVm, params);
Line 553: }
Line 554: }
--
To view, visit http://gerrit.ovirt.org/21851
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9778bcaf21b346a55992590159cabd8d78f0c66
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
