Alissa Bonas has uploaded a new change for review. Change subject: core: rename 2 methods in VdsHandler to lowercase ......................................................................
core: rename 2 methods in VdsHandler to lowercase Fix to start with lowercase per java naming standard, cleans findbugs warnings. Change-Id: Id6536bf050ec09077aa36412cc99bd93c168f32e Signed-off-by: Alissa Bonas <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsHandler.java 2 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/85/21885/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsCommand.java index d9cf697..1a007e68 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsCommand.java @@ -54,7 +54,7 @@ if (_oldVds != null && getParameters().getVdsStaticData() != null) { String compatibilityVersion = _oldVds.getVdsGroupCompatibilityVersion().toString(); - if (VdsHandler.IsUpdateValid(getParameters().getVdsStaticData(), _oldVds.getStaticData(), + if (VdsHandler.isUpdateValid(getParameters().getVdsStaticData(), _oldVds.getStaticData(), _oldVds.getStatus())) { if ("".equals(getParameters().getVdsStaticData().getName())) { addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_NAME_ALREADY_USED); @@ -218,7 +218,7 @@ } private boolean NeedToUpdateVdsBroker() { - return VdsHandler.IsFieldsUpdated(getParameters().getVdsStaticData(), _oldVds.getStaticData(), + return VdsHandler.isFieldsUpdated(getParameters().getVdsStaticData(), _oldVds.getStaticData(), UPDATE_FIELDS_VDS_BROKER); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsHandler.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsHandler.java index ea565f0..fc6a249 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsHandler.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsHandler.java @@ -51,12 +51,12 @@ mUpdateVdsStatic.setContainer(this); } - public static boolean IsUpdateValid(VdsStatic source, VdsStatic distination, VDSStatus status) { + public static boolean isUpdateValid(VdsStatic source, VdsStatic distination, VDSStatus status) { return mUpdateVdsStatic.IsUpdateValid(source, distination, status); } - public static boolean IsFieldsUpdated(VdsStatic source, VdsStatic destination, Iterable<String> list) { + public static boolean isFieldsUpdated(VdsStatic source, VdsStatic destination, Iterable<String> list) { return mUpdateVdsStatic.IsFieldsUpdated(source, destination, list); } -- To view, visit http://gerrit.ovirt.org/21885 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id6536bf050ec09077aa36412cc99bd93c168f32e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
