Daniel Erez has posted comments on this change.

Change subject: webadmin: Update list box upon arrow key press
......................................................................


Patch Set 2:

(1 comment)

....................................................
File 
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelListBox.java
Line 32:      *            Renderer for list box items.
Line 33:      */
Line 34:     public ListModelListBox(Renderer<T> renderer) {
Line 35:         super(renderer);
Line 36:         addKeyPressHandler(new KeyPressHandler() {
Is it the issue described in [1]?
If so, can we use suggested solution in comment #4?

[1] https://code.google.com/p/google-web-toolkit/issues/detail?id=2475
Line 37: 
Line 38:             @Override
Line 39:             public void onKeyPress(KeyPressEvent event) {
Line 40:                 int keyCode = event.getNativeEvent().getKeyCode();


-- 
To view, visit http://gerrit.ovirt.org/21719
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4cc9ac7e82c6d1c86886907cecd6eb5b83ac8444
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to