Shubhendu Tripathi has uploaded a new change for review.

Change subject: gluster: Show the wait icon if task status UNKNOWN
......................................................................

gluster: Show the wait icon if task status UNKNOWN

Modified to display the wait icon if the task status of rebelance /
remove bricks is UNKNOWN.
This is required if task is in progress and because of storage nodes
down the tstaus is returned as UNKNOWN.

Change-Id: I525231ea4127b247350fcb1f282a8592ae08a895
Bug-Url: https://bugzilla.redhat.com/1035601
Signed-off-by: Shubhendu Tripathi <[email protected]>
---
M 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VolumeActivityStatusCell.java
2 files changed, 14 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/14/21914/1

diff --git 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
index fc3be17..99a0860 100644
--- 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
+++ 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
@@ -3304,6 +3304,9 @@
     @DefaultStringValue("Cluster :")
     String rebalanceClusterVolume();
 
+    @DefaultStringValue("Rebalance in progress but status unknown. Unable to 
fetch the status at the moment.")
+    String rebalanceStatusUnknown();
+
     @DefaultStringValue("Brick removal in progress")
     String removeBrickInProgress();
 
@@ -3316,6 +3319,9 @@
     @DefaultStringValue("Migration completed, pending commit")
     String removeBrickCommitRequired();
 
+    @DefaultStringValue("Remove brick in progress but status unknown. Unable 
to fetch the status at the moment.")
+    String removeBrickStatusUnknown();
+
     //Volume Rebalance Status Table Columns
     @DefaultStringValue("Host")
     String rebalanceSessionHost();
diff --git 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VolumeActivityStatusCell.java
 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VolumeActivityStatusCell.java
index 2512d97..dbef58a 100644
--- 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VolumeActivityStatusCell.java
+++ 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VolumeActivityStatusCell.java
@@ -53,6 +53,10 @@
                 taskImage = resources.rebalanceCompleted();
                 tooltip = constants.rebalanceCompleted();
                 break;
+            case UNKNOWN:
+                taskImage = resources.waitImage();
+                tooltip = constants.rebalanceStatusUnknown();
+                break;
             default:
                 taskImage = null;
                 tooltip = ""; //$NON-NLS-1$
@@ -76,6 +80,10 @@
                 taskImage = resources.removeBrickCommitRequired();
                 tooltip = constants.removeBrickCommitRequired();
                 break;
+            case UNKNOWN:
+                taskImage = resources.waitImage();
+                tooltip = constants.removeBrickStatusUnknown();
+                break;
             default:
                 taskImage = null;
                 tooltip = ""; //$NON-NLS-1$


-- 
To view, visit http://gerrit.ovirt.org/21914
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I525231ea4127b247350fcb1f282a8592ae08a895
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to