Alissa Bonas has uploaded a new change for review. Change subject: core: rename methods to lowercase in XmlRpcObjectDescriptor ......................................................................
core: rename methods to lowercase in XmlRpcObjectDescriptor Rename 3 methods to start with lowercase - per Java naming conventions. Solves findbugs warnings. Change-Id: I9b218d4220a7b80d2482935e16bf5179a62f76db Signed-off-by: Alissa Bonas <[email protected]> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetVmsInfoReturnForXmlRpc.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/OneImageInfoReturnForXmlRpc.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/StoragePoolInfoReturnForXmlRpc.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/BrokerCommandBase.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/DevicesVisibilityMapReturnForXmlRpc.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetStorageDomainStatsVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/LUNListReturnForXmlRpc.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/OneStorageDomainInfoReturnForXmlRpc.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/OneStorageDomainStatsReturnForXmlRpc.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/OneVGReturnForXmlRpc.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ServerConnectionStatusReturnForXmlRpc.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/TaskInfoListReturnForXmlRpc.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/TaskStatusListReturnForXmlRpc.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VGListReturnForXmlRpc.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/xmlrpc/XmlRpcObjectDescriptor.java 15 files changed, 22 insertions(+), 22 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/20/21920/1 diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetVmsInfoReturnForXmlRpc.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetVmsInfoReturnForXmlRpc.java index 7a03aea..b110950 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetVmsInfoReturnForXmlRpc.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetVmsInfoReturnForXmlRpc.java @@ -16,7 +16,7 @@ builder.append("\n"); builder.append(super.toString()); builder.append("\n"); - XmlRpcObjectDescriptor.ToStringBuilder(vmlist, builder); + XmlRpcObjectDescriptor.toStringBuilder(vmlist, builder); return builder.toString(); } diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/OneImageInfoReturnForXmlRpc.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/OneImageInfoReturnForXmlRpc.java index 7968c57..7c8cad6 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/OneImageInfoReturnForXmlRpc.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/OneImageInfoReturnForXmlRpc.java @@ -22,7 +22,7 @@ builder.append("\n"); builder.append(super.toString()); builder.append("\n"); - XmlRpcObjectDescriptor.ToStringBuilder(mInfo, builder); + XmlRpcObjectDescriptor.toStringBuilder(mInfo, builder); return builder.toString(); } diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/StoragePoolInfoReturnForXmlRpc.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/StoragePoolInfoReturnForXmlRpc.java index fdf7727..72a1432 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/StoragePoolInfoReturnForXmlRpc.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/StoragePoolInfoReturnForXmlRpc.java @@ -20,8 +20,8 @@ builder.append("\n"); builder.append(super.toString()); builder.append("\n"); - XmlRpcObjectDescriptor.ToStringBuilder(mStoragePoolInfo, builder); - XmlRpcObjectDescriptor.ToStringBuilder(mDomainsList, builder); + XmlRpcObjectDescriptor.toStringBuilder(mStoragePoolInfo, builder); + XmlRpcObjectDescriptor.toStringBuilder(mDomainsList, builder); return builder.toString(); } diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/BrokerCommandBase.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/BrokerCommandBase.java index e8be4d4..521d547 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/BrokerCommandBase.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/BrokerCommandBase.java @@ -231,7 +231,7 @@ String returnValue; StringBuilder builder = new StringBuilder(); if (getReturnValueFromBroker() instanceof Map) { - XmlRpcObjectDescriptor.ToStringBuilder((Map<String, ?>) getReturnValueFromBroker(), builder); + XmlRpcObjectDescriptor.toStringBuilder((Map<String, ?>) getReturnValueFromBroker(), builder); returnValue = builder.toString(); } else { returnValue = getReturnValueFromBroker().toString(); diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/DevicesVisibilityMapReturnForXmlRpc.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/DevicesVisibilityMapReturnForXmlRpc.java index f0f0877..8d32c8c 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/DevicesVisibilityMapReturnForXmlRpc.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/DevicesVisibilityMapReturnForXmlRpc.java @@ -26,7 +26,7 @@ builder.append("\n"); builder.append(super.toString()); builder.append("\n"); - XmlRpcObjectDescriptor.ToStringBuilder(devicesVisibilityResult, builder); + XmlRpcObjectDescriptor.toStringBuilder(devicesVisibilityResult, builder); return builder.toString(); } diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetStorageDomainStatsVDSCommand.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetStorageDomainStatsVDSCommand.java index a8ed747..0e5df16 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetStorageDomainStatsVDSCommand.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetStorageDomainStatsVDSCommand.java @@ -64,7 +64,7 @@ if (alertCode == null || VdcBllErrors.forValue(alertCode) == null) { log.warnFormat("Unrecognized alert code: {0}.", alertCode); StringBuilder alertStringBuilder = new StringBuilder(); - XmlRpcObjectDescriptor.ToStringBuilder(alert, alertStringBuilder); + XmlRpcObjectDescriptor.toStringBuilder(alert, alertStringBuilder); log.infoFormat("The received alert is: {0}", alertStringBuilder.toString()); } else { alerts.add(VdcBllErrors.forValue(alertCode)); diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/LUNListReturnForXmlRpc.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/LUNListReturnForXmlRpc.java index 34df716..cdbbd3b 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/LUNListReturnForXmlRpc.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/LUNListReturnForXmlRpc.java @@ -18,7 +18,7 @@ builder.append("\n"); builder.append(super.toString()); builder.append("\n"); - XmlRpcObjectDescriptor.ToStringBuilder(lunList, builder); + XmlRpcObjectDescriptor.toStringBuilder(lunList, builder); return builder.toString(); } diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/OneStorageDomainInfoReturnForXmlRpc.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/OneStorageDomainInfoReturnForXmlRpc.java index 41ccdf2..c929ff4 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/OneStorageDomainInfoReturnForXmlRpc.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/OneStorageDomainInfoReturnForXmlRpc.java @@ -25,7 +25,7 @@ builder.append("\n"); builder.append(super.toString()); builder.append("\n"); - XmlRpcObjectDescriptor.ToStringBuilder(mStorageInfo, builder); + XmlRpcObjectDescriptor.toStringBuilder(mStorageInfo, builder); return builder.toString(); } } diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/OneStorageDomainStatsReturnForXmlRpc.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/OneStorageDomainStatsReturnForXmlRpc.java index 67bc542..e90b05d 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/OneStorageDomainStatsReturnForXmlRpc.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/OneStorageDomainStatsReturnForXmlRpc.java @@ -19,7 +19,7 @@ builder.append("\n"); builder.append(super.toString()); builder.append("\n"); - XmlRpcObjectDescriptor.ToStringBuilder(mStorageStats, builder); + XmlRpcObjectDescriptor.toStringBuilder(mStorageStats, builder); return builder.toString(); } diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/OneVGReturnForXmlRpc.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/OneVGReturnForXmlRpc.java index 0dd3cbd..85b70bb 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/OneVGReturnForXmlRpc.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/OneVGReturnForXmlRpc.java @@ -17,7 +17,7 @@ builder.append("\n"); builder.append(super.toString()); builder.append("\n"); - XmlRpcObjectDescriptor.ToStringBuilder(vgInfo, builder); + XmlRpcObjectDescriptor.toStringBuilder(vgInfo, builder); return builder.toString(); } diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ServerConnectionStatusReturnForXmlRpc.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ServerConnectionStatusReturnForXmlRpc.java index 86ecccc..358cda9 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ServerConnectionStatusReturnForXmlRpc.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ServerConnectionStatusReturnForXmlRpc.java @@ -19,7 +19,7 @@ builder.append("\n"); builder.append(super.toString()); builder.append("\n"); - XmlRpcObjectDescriptor.ToStringBuilder(mStatusList, builder); + XmlRpcObjectDescriptor.toStringBuilder(mStatusList, builder); return builder.toString(); } diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/TaskInfoListReturnForXmlRpc.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/TaskInfoListReturnForXmlRpc.java index c5bbad0..17014ad 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/TaskInfoListReturnForXmlRpc.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/TaskInfoListReturnForXmlRpc.java @@ -19,7 +19,7 @@ builder.append("\n"); builder.append(super.toString()); builder.append("\n"); - XmlRpcObjectDescriptor.ToStringBuilder(TaskInfoList, builder); + XmlRpcObjectDescriptor.toStringBuilder(TaskInfoList, builder); return builder.toString(); } diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/TaskStatusListReturnForXmlRpc.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/TaskStatusListReturnForXmlRpc.java index 32c3734..4da71fe 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/TaskStatusListReturnForXmlRpc.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/TaskStatusListReturnForXmlRpc.java @@ -17,7 +17,7 @@ builder.append("\n"); builder.append(super.toString()); builder.append("\n"); - XmlRpcObjectDescriptor.ToStringBuilder(TaskStatusList, builder); + XmlRpcObjectDescriptor.toStringBuilder(TaskStatusList, builder); return builder.toString(); } diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VGListReturnForXmlRpc.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VGListReturnForXmlRpc.java index f13ca11..b2e9200 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VGListReturnForXmlRpc.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VGListReturnForXmlRpc.java @@ -19,7 +19,7 @@ builder.append("\n"); builder.append(super.toString()); builder.append("\n"); - XmlRpcObjectDescriptor.ToStringBuilder(vgList, builder); + XmlRpcObjectDescriptor.toStringBuilder(vgList, builder); return builder.toString(); } diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/xmlrpc/XmlRpcObjectDescriptor.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/xmlrpc/XmlRpcObjectDescriptor.java index 349cb13..72561e2 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/xmlrpc/XmlRpcObjectDescriptor.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/xmlrpc/XmlRpcObjectDescriptor.java @@ -3,7 +3,7 @@ import java.util.Map; public class XmlRpcObjectDescriptor { - public static void ToStringBuilder(java.util.Map<String, ?> map, StringBuilder builder) { + public static void toStringBuilder(java.util.Map<String, ?> map, StringBuilder builder) { if (map == null) return; @@ -11,12 +11,12 @@ if (entry.getValue() instanceof java.util.Map) { builder.append(String.format("%1$s:", entry.getKey())); builder.append("\n"); - ToStringBuilder((java.util.Map<String, Object>) entry.getValue(), builder); + toStringBuilder((java.util.Map<String, Object>) entry.getValue(), builder); builder.append("\n"); } else if (!(entry.getValue() instanceof String) && entry.getValue() instanceof Iterable) { builder.append(String.format("%1$s:", entry.getKey())); builder.append("\n"); - ToStringBuilder((Iterable) (entry.getValue()), builder); + toStringBuilder((Iterable) (entry.getValue()), builder); builder.append("\n"); } else { builder.append(String.format("%1$s = %2$s", entry.getKey(), entry.getValue().toString())); @@ -25,22 +25,22 @@ } } - public static void ToStringBuilder(Map[] xmlRpc, StringBuilder builder) { + public static void toStringBuilder(Map[] xmlRpc, StringBuilder builder) { if (xmlRpc == null) return; for (Map entry : xmlRpc) { - ToStringBuilder(entry, builder); + toStringBuilder(entry, builder); } } - private static void ToStringBuilder(Iterable xmlRpc, StringBuilder builder) { + private static void toStringBuilder(Iterable xmlRpc, StringBuilder builder) { if (xmlRpc == null) return; for (Object value : xmlRpc) { if (value instanceof Iterable) { - ToStringBuilder((Iterable) (value), builder); + toStringBuilder((Iterable) (value), builder); } else { builder.append(value.toString()); builder.append("\n"); -- To view, visit http://gerrit.ovirt.org/21920 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9b218d4220a7b80d2482935e16bf5179a62f76db Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
