Allon Mureinik has posted comments on this change.
Change subject: engine : Fix for findbugs warnings introduced in SizeConverter
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/SizeConverter.java
Line 59: return new Pair<SizeConverter.SizeUnit,
Double>(currentUnitPair.getSecond(),
Line 60: Double.valueOf(SizeConverter.convert(size,
inUnit, currentUnitPair.getSecond()).doubleValue()));
Line 61: }
Line 62: }
Line 63: return new Pair<SizeConverter.SizeUnit,
Double>(SizeUnit.BYTES, new Double(Long.valueOf(size)));
wouldn't it be easier to have use "Double.valueOf(size)" ?
Line 64: }
Line 65:
Line 66: private static class CompareUnits implements Comparator<Pair<Long,
SizeUnit>> {
Line 67:
--
To view, visit http://gerrit.ovirt.org/21919
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I570e4e69ea6229346c1d20e8f917994c6875eb49
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
