Alissa Bonas has uploaded a new change for review.

Change subject: frontend: ignore in findbugs EventArgs unconfirmed cast errors
......................................................................

frontend: ignore in findbugs EventArgs unconfirmed cast errors

Ignore in findbugs errors related to casting EventArgs.
The casting is safe in this case, and a future refactoring
will make findbug warning resolved in any case.(RFE #1034844)
This is patch #6 following
http://gerrit.ovirt.org/#/c/21903/

Change-Id: Ifa2b17e7af8e599234648ba6319b272f092679d5
Signed-off-by: Alissa Bonas <[email protected]>
---
M frontend/webadmin/modules/gwt-common/exclude-filters.xml
M frontend/webadmin/modules/userportal-gwtp/exclude-filters.xml
M frontend/webadmin/modules/webadmin/exclude-filters.xml
3 files changed, 45 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/57/21957/1

diff --git a/frontend/webadmin/modules/gwt-common/exclude-filters.xml 
b/frontend/webadmin/modules/gwt-common/exclude-filters.xml
index a45834b..1b3fab1 100644
--- a/frontend/webadmin/modules/gwt-common/exclude-filters.xml
+++ b/frontend/webadmin/modules/gwt-common/exclude-filters.xml
@@ -243,6 +243,11 @@
     </Match>
 
     <Match>
+      <Class 
name="org.ovirt.engine.ui.common.widget.uicommon.popup.vm.VmDiskPopupWidget$33" 
/>
+      <Bug pattern="BC_UNCONFIRMED_CAST"/>
+    </Match>
+
+    <Match>
       <Class 
name="org.ovirt.engine.ui.common.widget.uicommon.popup.vm.VmMakeTemplatePopupWidget$4"
 />
       <Bug pattern="BC_UNCONFIRMED_CAST"/>
     </Match>
diff --git a/frontend/webadmin/modules/userportal-gwtp/exclude-filters.xml 
b/frontend/webadmin/modules/userportal-gwtp/exclude-filters.xml
index 14f1a07..5737cb3 100644
--- a/frontend/webadmin/modules/userportal-gwtp/exclude-filters.xml
+++ b/frontend/webadmin/modules/userportal-gwtp/exclude-filters.xml
@@ -59,5 +59,10 @@
      <Bug code="UuF"/>
    </Match>
 
+   <Match>
+     <Class 
name="org.ovirt.engine.ui.userportal.uicommon.model.vm.VmMonitorModelProvider$1"
 />
+     <Bug pattern="BC_UNCONFIRMED_CAST"/>
+   </Match>
+
 
  </FindBugsFilter>
diff --git a/frontend/webadmin/modules/webadmin/exclude-filters.xml 
b/frontend/webadmin/modules/webadmin/exclude-filters.xml
index 3a6a836..05c7ef5 100644
--- a/frontend/webadmin/modules/webadmin/exclude-filters.xml
+++ b/frontend/webadmin/modules/webadmin/exclude-filters.xml
@@ -281,4 +281,39 @@
       <Bug pattern="BC_UNCONFIRMED_CAST"/>
     </Match>
 
+    <Match>
+      <Class 
name="org.ovirt.engine.ui.webadmin.section.main.presenter.SearchPanelPresenterWidget$1"
 />
+      <Bug pattern="BC_UNCONFIRMED_CAST"/>
+    </Match>
+
+    <Match>
+      <Class 
name="org.ovirt.engine.ui.webadmin.section.main.presenter.popup.AbstractNetworkPopupPresenterWidget$1"
 />
+      <Bug pattern="BC_UNCONFIRMED_CAST"/>
+    </Match>
+
+    <Match>
+      <Class 
name="org.ovirt.engine.ui.webadmin.section.main.presenter.popup.cluster.ClusterPopupPresenterWidget$1"
 />
+      <Bug pattern="BC_UNCONFIRMED_CAST"/>
+    </Match>
+
+    <Match>
+      <Class 
name="org.ovirt.engine.ui.webadmin.section.main.view.popup.gluster.RemoveBrickPopupView$2"
 />
+      <Bug pattern="BC_UNCONFIRMED_CAST"/>
+    </Match>
+
+    <Match>
+      <Class 
name="org.ovirt.engine.ui.webadmin.section.main.view.popup.gluster.VolumePopupView$4"
 />
+      <Bug pattern="BC_UNCONFIRMED_CAST"/>
+    </Match>
+
+    <Match>
+      <Class 
name="org.ovirt.engine.ui.webadmin.section.main.view.popup.gluster.VolumeRebalanceStatusPopupView$9"
 />
+      <Bug pattern="BC_UNCONFIRMED_CAST"/>
+    </Match>
+
+    <Match>
+      <Class 
name="org.ovirt.engine.ui.webadmin.section.main.view.popup.guide.GuidePopupView$1"
 />
+      <Bug pattern="BC_UNCONFIRMED_CAST"/>
+    </Match>
+
 </FindBugsFilter>


-- 
To view, visit http://gerrit.ovirt.org/21957
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifa2b17e7af8e599234648ba6319b272f092679d5
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to