Alissa Bonas has uploaded a new change for review. Change subject: core: rename method to lowercase in BaseHandler ......................................................................
core: rename method to lowercase in BaseHandler Change-Id: Ia8911920fb0e183e25c4d1ccf00259feaf5d1948 Signed-off-by: Alissa Bonas <[email protected]> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/backendinterfaces/BaseHandler.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/IObjectDescriptorContainer.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ObjectIdentityChecker.java 3 files changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/64/21964/1 diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/backendinterfaces/BaseHandler.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/backendinterfaces/BaseHandler.java index 86461f2..222f967 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/backendinterfaces/BaseHandler.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/backendinterfaces/BaseHandler.java @@ -13,9 +13,9 @@ * Returns a boolean indication regarding whether it is allowed to update a specified field of a specified object in * a specified status. Example for overriding this function: * - * public override bool CanUpdateField(object obj, string fieldName, Enum status) { VDS vds = obj as VDS; VDSStatus + * public override bool canUpdateField(object obj, string fieldName, Enum status) { VDS vds = obj as VDS; VDSStatus * vdsStatus = (VDSStatus)status; switch (vdsStatus) { case Maintenance: ... ... ... default: return - * base.CanUpdateField(....) } } + * base.canUpdateField(....) } } * * @param obj * The object to update field in. @@ -26,7 +26,7 @@ * @return True if fieldName is allowed for update, false otherwise. */ @Override - public boolean CanUpdateField(Object obj, String fieldName, Enum<?> status) { + public boolean canUpdateField(Object obj, String fieldName, Enum<?> status) { return true; } diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/IObjectDescriptorContainer.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/IObjectDescriptorContainer.java index df8b082..cce3b52 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/IObjectDescriptorContainer.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/IObjectDescriptorContainer.java @@ -1,5 +1,5 @@ package org.ovirt.engine.core.common.utils; public interface IObjectDescriptorContainer { - boolean CanUpdateField(Object obj, String fieldName, Enum<?> status); + boolean canUpdateField(Object obj, String fieldName, Enum<?> status); } diff --git a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ObjectIdentityChecker.java b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ObjectIdentityChecker.java index 241ceb2..d79a2c6 100644 --- a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ObjectIdentityChecker.java +++ b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ObjectIdentityChecker.java @@ -126,7 +126,7 @@ boolean returnValue = true; if (!IsFieldUpdatable(name)) { if (fieldContainer != null && container != null - && !container.CanUpdateField(fieldContainer, name, status)) { + && !container.canUpdateField(fieldContainer, name, status)) { returnValue = false; } else { Set<String> values = dictionary.get(status); -- To view, visit http://gerrit.ovirt.org/21964 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia8911920fb0e183e25c4d1ccf00259feaf5d1948 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
