Lior Vernia has posted comments on this change.
Change subject: webadmin: Small improvements to AddRemoveRowWidget
......................................................................
Patch Set 2:
(1 comment)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AddRemoveRowWidget.java
Line 226: * @param widget
Line 227: * the widget added.
Line 228: */
Line 229: protected void onAdd(T value, V widget) {
Line 230: // do nothing
Adding the new value to modelItems (the commit) happens in addGhostEntry(),
which is invoked not only upon pressing the "+" button but also in the
initialization of the widget (but is also always invoked as part of the button
press sequence).
It might be better to indeed put the commit here, because that would be both
more evident and overrideable in derived classes if this behavior isn't
desired. Then onAdd() could be also called programatically as part of the
initialization. I just hope I'm not neglecting any good reason not to do it.
I'll give it a shot and see if anything seems to be broken.
Line 231: }
Line 232:
Line 233: /**
Line 234: * This method is called straight after an entry is removed by
pressing the minues button. Note that this entry will
--
To view, visit http://gerrit.ovirt.org/21627
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I645c6984f9bcfe6f00f8b7eb07313f4d4f3d7043
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
