Alissa Bonas has uploaded a new change for review. Change subject: engine: rename several methods in CommandsFactory ......................................................................
engine: rename several methods in CommandsFactory Change-Id: I74412dd0c545f3806db6156964b857756e87b40d Signed-off-by: Alissa Bonas <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandAsyncTask.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultipleActionsRunner.java 4 files changed, 11 insertions(+), 11 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/37/22037/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java index f01b9d5..86f09c5 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java @@ -317,7 +317,7 @@ for (KeyValue commandSnapshot : commandSnapshots) { // create an instance of the related command by its class name and command id CommandBase<?> cmd = - CommandsFactory.CreateCommand(commandSnapshot.getValue().toString(), + CommandsFactory.createCommand(commandSnapshot.getValue().toString(), (Guid) commandSnapshot.getKey()); if (cmd != null) { try { @@ -389,7 +389,7 @@ result.setSucceeded(false); } else { - CommandBase<?> command = CommandsFactory.CreateCommand(actionType, parameters); + CommandBase<?> command = CommandsFactory.createCommand(actionType, parameters); result = runAction(command, runAsInternal, context); } return result; @@ -442,7 +442,7 @@ public VdcReturnValueBase endAction(VdcActionType actionType, VdcActionParametersBase parameters, CommandContext context) { - CommandBase<?> command = CommandsFactory.CreateCommand(actionType, parameters); + CommandBase<?> command = CommandsFactory.createCommand(actionType, parameters); command.setContext(context); return command.endAction(); } @@ -580,7 +580,7 @@ switch (parameters.getActionType()) { case LoginUser: case LoginAdminUser: - CommandBase<?> command = CommandsFactory.CreateCommand(parameters.getActionType(), parameters); + CommandBase<?> command = CommandsFactory.createCommand(parameters.getActionType(), parameters); command.insertAsyncTaskPlaceHolders(); return command.executeAction(); default: @@ -648,7 +648,7 @@ } protected QueriesCommandBase<?> createQueryCommand(VdcQueryType actionType, VdcQueryParametersBase parameters) { - return CommandsFactory.CreateQueryCommand(actionType, parameters); + return CommandsFactory.createQueryCommand(actionType, parameters); } @Override @@ -667,7 +667,7 @@ @Override public CommandBase<?> createAction(VdcActionType actionType, VdcActionParametersBase parameters) { - return CommandsFactory.CreateCommand(actionType, parameters); + return CommandsFactory.createCommand(actionType, parameters); } @Override diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandAsyncTask.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandAsyncTask.java index b641277..e251a2b 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandAsyncTask.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandAsyncTask.java @@ -53,7 +53,7 @@ if (duringInit && isNewCommandAdded) { CommandBase<?> command = - CommandsFactory.CreateCommand(parameters.getDbAsyncTask().getaction_type(), + CommandsFactory.createCommand(parameters.getDbAsyncTask().getaction_type(), parameters.getDbAsyncTask().getActionParameters()); if (!command.acquireLockAsyncTask()) { log.warnFormat("Failed to acquire locks for command {0} with parameters {1}", diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java index c5f5b52..96e4dee 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandsFactory.java @@ -43,7 +43,7 @@ new ConcurrentHashMap<String, Class<CommandBase<? extends VdcActionParametersBase>>>(VdcActionType.values().length); @SuppressWarnings("unchecked") - public static <P extends VdcActionParametersBase> CommandBase<P> CreateCommand(VdcActionType action, P parameters) { + public static <P extends VdcActionParametersBase> CommandBase<P> createCommand(VdcActionType action, P parameters) { try { Constructor<CommandBase<? extends VdcActionParametersBase>> constructor = findCommandConstructor(getCommandClass(action.name(), CommandSuffix), parameters.getClass()); @@ -69,7 +69,7 @@ * the command id used by the compensation. * @return command instance or null if exception occurred. */ - public static CommandBase<?> CreateCommand(String className, Guid commandId) { + public static CommandBase<?> createCommand(String className, Guid commandId) { Constructor<?> constructor = null; Boolean isAcessible = null; try { @@ -92,7 +92,7 @@ } } - public static QueriesCommandBase<?> CreateQueryCommand(VdcQueryType query, VdcQueryParametersBase parameters) { + public static QueriesCommandBase<?> createQueryCommand(VdcQueryType query, VdcQueryParametersBase parameters) { Class<?> type = null; try { type = getCommandClass(query.name(), QueryPrefix); diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultipleActionsRunner.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultipleActionsRunner.java index a72fbd9..6b9316e 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultipleActionsRunner.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultipleActionsRunner.java @@ -62,7 +62,7 @@ parameter.setMultipleAction(true); returnValue = ExecutionHandler.evaluateCorrelationId(parameter); if (returnValue == null) { - CommandBase<?> command = CommandsFactory.CreateCommand(_actionType, parameter); + CommandBase<?> command = CommandsFactory.createCommand(_actionType, parameter); command.setInternalExecution(isInternal); getCommands().add(command); } else { -- To view, visit http://gerrit.ovirt.org/22037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I74412dd0c545f3806db6156964b857756e87b40d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
