Moti Asayag has uploaded a new change for review. Change subject: engine: Extract method for network sync-ness ......................................................................
engine: Extract method for network sync-ness A method is extract in order to provide the ability to use the check if a network configured on host is synchronized with its logical definition. Change-Id: I91668eacbde561ff0392a86c8fc29c35ead6ac9d Signed-off-by: Moti Asayag <[email protected]> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java 1 file changed, 7 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/49/22049/1 diff --git a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java index eab1de8..bd1be59 100644 --- a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java +++ b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java @@ -157,9 +157,7 @@ if (networks.containsKey(iface.getNetworkName())) { Network network = networks.get(iface.getNetworkName()); - if ((network.getMtu() == 0 || iface.getMtu() == network.getMtu()) - && ObjectUtils.equals(iface.getVlanId(), network.getVlanId()) - && iface.isBridged() == network.isVmNetwork()) { + if (isNetworkInSync(iface, network)) { return new VdsNetworkInterface.NetworkImplementationDetails(true, true); } else { return new VdsNetworkInterface.NetworkImplementationDetails(false, true); @@ -169,6 +167,12 @@ } } + public static boolean isNetworkInSync(VdsNetworkInterface iface, Network network) { + return (network.getMtu() == 0 || iface.getMtu() == network.getMtu()) + && ObjectUtils.equals(iface.getVlanId(), network.getVlanId()) + && iface.isBridged() == network.isVmNetwork(); + } + /** * Returns true if a given network is non-VM network with no Vlan tagging, else false. * -- To view, visit http://gerrit.ovirt.org/22049 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I91668eacbde561ff0392a86c8fc29c35ead6ac9d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
