Moti Asayag has uploaded a new change for review.
Change subject: restapi: Add 'apply' parameter to network update
......................................................................
restapi: Add 'apply' parameter to network update
By providing the 'apply' property we allow the
administrator to provision the network change
to all of the hosts.
Editing the network is done on rest via PUT method on:
/api/networks/{network:id}/
/api/datacenters/{datacenter:id}/networks/{network:id}/
By providing the optional element apply (default is false):
<network>
...
<apply>true</apply>
</network>
Change-Id: Ic752111eb05e331e4e7e8a3c37000207b81058cf
See: http://www.ovirt.org/Features/EditProvisionedNetwork#REST
Signed-off-by: Moti Asayag <[email protected]>
---
M
backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
M
backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
M
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendNetworkResource.java
3 files changed, 9 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/54/22054/1
diff --git
a/backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
b/backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
index 2d95d84..33ba1f2 100644
---
a/backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
+++
b/backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
@@ -1945,6 +1945,7 @@
<xs:element ref="usages" minOccurs="0" maxOccurs="1"/>
<xs:element name="required" type="xs:boolean" minOccurs="0"/>
<xs:element name="profile_required" type="xs:boolean" minOccurs="0"
maxOccurs="1"/>
+ <xs:element name="apply" type="xs:boolean" minOccurs="0"
maxOccurs="1"/>
</xs:sequence>
</xs:extension>
</xs:complexContent>
diff --git
a/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
b/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
index b43afb3..1caae48 100644
---
a/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
+++
b/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
@@ -2746,7 +2746,7 @@
- mandatoryArguments: {}
optionalArguments: {network.name: 'xs:string', network.description:
'xs:string', network.comment: 'xs:string', network.vlan.id: 'xs:string',
network.ip.address: 'xs:string', network.ip.gateway: 'xs:string',
network.ip.netmask: 'xs:string',
- network.display: 'xs:boolean', network.stp: 'xs:boolean',
network.mtu: 'xs:int'}
+ network.display: 'xs:boolean', network.stp: 'xs:boolean',
network.mtu: 'xs:int', network.apply: 'xs:boolean'}
description: update the specified network in the system
urlparams: {}
headers:
diff --git
a/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendNetworkResource.java
b/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendNetworkResource.java
index 1aedb44..fea89f3 100644
---
a/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendNetworkResource.java
+++
b/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendNetworkResource.java
@@ -42,7 +42,13 @@
@Override
public VdcActionParametersBase getParameters(Network incoming,
org.ovirt.engine.core.common.businessentities.network.Network entity) {
org.ovirt.engine.core.common.businessentities.network.Network
updated = getMapper(modelType,
org.ovirt.engine.core.common.businessentities.network.Network.class).map(incoming,
entity);
- return new
AddNetworkStoragePoolParameters(entity.getDataCenterId(), updated);
+ AddNetworkStoragePoolParameters parameters =
+ new
AddNetworkStoragePoolParameters(entity.getDataCenterId(), updated);
+ if (incoming.isSetApply()) {
+ parameters.setConfigureHosts(incoming.isApply());
+ }
+
+ return parameters;
}
}
--
To view, visit http://gerrit.ovirt.org/22054
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic752111eb05e331e4e7e8a3c37000207b81058cf
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
