Moti Asayag has uploaded a new change for review. Change subject: engine: Introduce PersistentSetupNetworksCommand ......................................................................
engine: Introduce PersistentSetupNetworksCommand The new command combines a sequence of 2 commands: 1. SetupNetworksCommand and upon successful execution: 2. CommitNetworkChangesCommand The command will be used internally only, when a network changes to multiple hosts are required, and the changes should be persisted. Change-Id: Ie0a29e970ecbf02a7a3387a26f482de9200a3719 Signed-off-by: Moti Asayag <[email protected]> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/PersistentSetupNetworksCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 2 files changed, 34 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/51/22051/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/PersistentSetupNetworksCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/PersistentSetupNetworksCommand.java new file mode 100644 index 0000000..c422e3a --- /dev/null +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/PersistentSetupNetworksCommand.java @@ -0,0 +1,33 @@ +package org.ovirt.engine.core.bll.network.host; + +import org.ovirt.engine.core.bll.NonTransactiveCommandAttribute; +import org.ovirt.engine.core.bll.VdsCommand; +import org.ovirt.engine.core.common.action.SetupNetworksParameters; +import org.ovirt.engine.core.common.action.VdcActionType; +import org.ovirt.engine.core.common.action.VdcReturnValueBase; +import org.ovirt.engine.core.common.action.VdsActionParameters; +import org.ovirt.engine.core.common.errors.VdcBllMessages; + +@NonTransactiveCommandAttribute +public class PersistentSetupNetworksCommand<T extends SetupNetworksParameters> extends VdsCommand<T> { + + public PersistentSetupNetworksCommand(T parameters) { + super(parameters); + setVdsId(parameters.getVdsId()); + } + + @Override + protected void setActionMessageParameters() { + addCanDoActionMessage(VdcBllMessages.VAR__ACTION__SETUP); + addCanDoActionMessage(VdcBllMessages.VAR__TYPE__NETWORKS); + } + + @Override + protected void executeCommand() { + VdcReturnValueBase returnValue = getBackend().runInternalAction(VdcActionType.SetupNetworks, getParameters()); + if (returnValue.getSucceeded()) { + getBackend().runInternalAction(VdcActionType.CommitNetworkChanges, + new VdsActionParameters(getParameters().getVdsId())); + } + } +} diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java index dd45ae1..33ff7e8 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java @@ -85,6 +85,7 @@ UpdateNetwork(156, ActionGroup.CONFIGURE_STORAGE_POOL_NETWORK, false, QuotaDependency.NONE), CommitNetworkChanges(157, ActionGroup.CONFIGURE_HOST_NETWORK, QuotaDependency.NONE), SetupNetworks(158, ActionGroup.CONFIGURE_HOST_NETWORK, QuotaDependency.NONE), + PersistentSetupNetworks(159, QuotaDependency.NONE), // VnicProfile Commands AddVnicProfile(160, ActionGroup.CREATE_NETWORK_VNIC_PROFILE, false, QuotaDependency.NONE), -- To view, visit http://gerrit.ovirt.org/22051 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie0a29e970ecbf02a7a3387a26f482de9200a3719 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
