Oved Ourfali has uploaded a new change for review. Change subject: utils: write log message when file.delete fails in utils ......................................................................
utils: write log message when file.delete fails in utils Change-Id: I64ecdb968f2825b5a1da3d152b1213e545fa52d1 Signed-off-by: Oved Ourfali <[email protected]> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ConfigurationProvider.java M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java 2 files changed, 6 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/68/22068/1 diff --git a/backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ConfigurationProvider.java b/backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ConfigurationProvider.java index 16ff83d..314a43c 100644 --- a/backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ConfigurationProvider.java +++ b/backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ConfigurationProvider.java @@ -124,7 +124,9 @@ protected void disposePassFile(File file) { if (file != null) { if (file.exists()) { - file.delete(); + if (!file.delete()) { + log.info("Failed deleting file " + file.getAbsolutePath() + ". Continuing anyway."); + } } } } diff --git a/backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java b/backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java index e9e9056..91e267e 100644 --- a/backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java +++ b/backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java @@ -1145,7 +1145,9 @@ private static void deleteFile(String filePath) { File file = new File(filePath); if (file.exists()) { - file.delete(); + if (!file.delete()) { + log.info("Failed deleting file " + file.getAbsolutePath() + ". Continuing anyway."); + } } } } -- To view, visit http://gerrit.ovirt.org/22068 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I64ecdb968f2825b5a1da3d152b1213e545fa52d1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
