Omer Frenkel has posted comments on this change.
Change subject: gluster: add force support to add-bricks
......................................................................
Patch Set 7:
(1 comment)
no canDoAction changes needed? sometimes some checks are skipped if user
selects force, maybe block using force in non compatible cluster? currently it
will be ignored, user might be a little confused
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/AddBricksToGlusterVolumeCommand.java
Line 99: getGlusterVolumeName(),
Line 100: bricksList,
Line 101: replicaCount,
Line 102: stripeCount,
Line 103: force));
you could pass the compatibility version as well instead of getting the host
again from db later just for that.
Line 104:
Line 105: setSucceeded(returnValue.getSucceeded());
Line 106:
Line 107: if (getSucceeded()) {
--
To view, visit http://gerrit.ovirt.org/21403
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I65b3e96d759a0b09b625da793b6c63b93f8c2131
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Ramesh N <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
