Sergey Gotliv has posted comments on this change.
Change subject: core,webadmin: Plug disk to VM when adding a new disk
......................................................................
Patch Set 2:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
Line 555: }
Line 556:
Line 557: private void plugDiskToVmIfNeeded() {
Line 558: if (Boolean.TRUE.equals(getParameters().getPlugDiskToVm()) &&
getVm() != null && getVm().getStatus() != VMStatus.Down) {
Line 559: HotPlugDiskToVmParameters params = new
HotPlugDiskToVmParameters(getVmId(), getParameters().getDiskInfo().getId());
Liron, hotplug command takes several locks, exclusive on disk and boot and
shared on VM.
Which one is not needed?
Line 560: VdcReturnValueBase returnValue =
Backend.getInstance().runInternalAction(VdcActionType.HotPlugDiskToVm, params);
Line 561: if (!returnValue.getSucceeded()) {
Line 562: AuditLogDirector.log(this,
AuditLogType.USER_FAILED_HOTPLUG_DISK);
Line 563: }
--
To view, visit http://gerrit.ovirt.org/21851
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9778bcaf21b346a55992590159cabd8d78f0c66
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Cheryn Tan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
