Allon Mureinik has posted comments on this change. Change subject: engine: supress findbugs warnings in GlusterUtil ......................................................................
Patch Set 1: Code-Review-1 (2 comments) .................................................... Commit Message Line 6: Line 7: engine: supress findbugs warnings in GlusterUtil Line 8: Line 9: Supress 2 warnings caused by incorrect interpretation Line 10: of Java7 syntax. This message is not accurate. When compiling the autoclosable syntax in Java 7, certain compilers[1] may create bytecode that contains redundant null checks in it. FB is not incorrect - the byte code can definately be improved. However, we are not about to limit ourselves to old java 6 syntax just because of a compiler stupidity. The reason we want to suppress this warning is because its unavoidable, not incorrect. Line 11: Line 12: Change-Id: I3d60d51747be3908fb78427b50698c6d4d8d9ac0 .................................................... File backend/manager/modules/bll/exclude-filters.xml Line 127: <Bug code="HE"/> Line 128: </Match> Line 129: Line 130: <Match> Line 131: <Class name="org.ovirt.engine.core.bll.utils.GlusterUtil" /> Please do this per method and not all-out. Line 132: <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE"/> Line 133: </Match> Line 134: -- To view, visit http://gerrit.ovirt.org/22095 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d60d51747be3908fb78427b50698c6d4d8d9ac0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
