Vojtech Szocs has uploaded a new change for review. Change subject: webadmin,userportal: Fix GWT DevMode refresh issue ......................................................................
webadmin,userportal: Fix GWT DevMode refresh issue GWT SDK version 2.5.1 + gwt-maven-plugin version 2.5.1 combo has an issue where GUI code change (modifying *.java file) isn't reflected into (running) GWT DevMode debug session: https://jira.codehaus.org/browse/MGWT-350 In practice, this means developer has to restart GWT DevMode each time he (she) makes GUI code change, which is not good. This patch modifies 'gwtdev' Maven build profile to work around this issue by using gwt-maven-plugin version 2.4.0 instead of (GWT SDK based) version 2.5.1. Note that 'gwtdev' profile is used only for GWT debugging purposes, therefore this patch has no impact on regular GWT build. Change-Id: I831d0b2ce203bea3a4ffa1b42c27a3d0c300c7a1 Signed-off-by: Vojtech Szocs <[email protected]> --- M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml M pom.xml 3 files changed, 20 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/08/22108/1 diff --git a/frontend/webadmin/modules/userportal-gwtp/pom.xml b/frontend/webadmin/modules/userportal-gwtp/pom.xml index c5bc224..2a90c63 100644 --- a/frontend/webadmin/modules/userportal-gwtp/pom.xml +++ b/frontend/webadmin/modules/userportal-gwtp/pom.xml @@ -246,6 +246,15 @@ <profile> <id>gwtdev</id> <build> + <pluginManagement> + <plugins> + <plugin> + <groupId>org.codehaus.mojo</groupId> + <artifactId>gwt-maven-plugin</artifactId> + <version>${gwt-maven-plugin.workingRefresh.version}</version> + </plugin> + </plugins> + </pluginManagement> <plugins> <plugin> <groupId>org.codehaus.mojo</groupId> diff --git a/frontend/webadmin/modules/webadmin/pom.xml b/frontend/webadmin/modules/webadmin/pom.xml index f812a6b..5f4aaa7 100644 --- a/frontend/webadmin/modules/webadmin/pom.xml +++ b/frontend/webadmin/modules/webadmin/pom.xml @@ -246,6 +246,15 @@ <profile> <id>gwtdev</id> <build> + <pluginManagement> + <plugins> + <plugin> + <groupId>org.codehaus.mojo</groupId> + <artifactId>gwt-maven-plugin</artifactId> + <version>${gwt-maven-plugin.workingRefresh.version}</version> + </plugin> + </plugins> + </pluginManagement> <plugins> <plugin> <groupId>org.codehaus.mojo</groupId> diff --git a/pom.xml b/pom.xml index adfb6e9..dbe7cf0 100644 --- a/pom.xml +++ b/pom.xml @@ -101,6 +101,8 @@ <maven-resources-plugin.version>2.4.3</maven-resources-plugin.version> <exec-maven-plugin.version>1.2</exec-maven-plugin.version> <maven-ejb-plugin.version>2.3</maven-ejb-plugin.version> + <!-- https://jira.codehaus.org/browse/MGWT-350 --> + <gwt-maven-plugin.workingRefresh.version>2.4.0</gwt-maven-plugin.workingRefresh.version> </properties> <dependencyManagement> <dependencies> -- To view, visit http://gerrit.ovirt.org/22108 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I831d0b2ce203bea3a4ffa1b42c27a3d0c300c7a1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
