Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Disable new Pools popup when no Templates are
available
......................................................................
Patch Set 4:
(3 comments)
What about a DAO test?
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmTemplateCountQuery.java
Line 9: }
Line 10:
Line 11: @Override
Line 12: protected void executeQueryCommand() {
Line 13:
getQueryReturnValue().setReturnValue(DbFacade.getInstance().getVmTemplateDao().getCount());
please separate to a method, getVmTemplateDao() and use getDbFacade().
Line 14: }
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDAODbFacadeImpl.java
Line 314:
entity.setVmTemplate(VMTemplateRowMapper.instance.mapRow(rs, rowNum));
Line 315: return entity;
Line 316: }
Line 317: }
Line 318:
remove
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/PoolModelBehaviorBase.java
Line 1: package org.ovirt.engine.ui.uicommonweb.models.vms;
Line 2:
Line 3: import java.util.ArrayList;
Line 4: import java.util.List;
Line 5:
remove from patch
Line 6: import org.ovirt.engine.core.common.businessentities.DisplayType;
Line 7: import org.ovirt.engine.core.common.businessentities.StoragePool;
Line 8: import org.ovirt.engine.core.common.businessentities.StoragePoolStatus;
Line 9: import org.ovirt.engine.core.common.businessentities.VDSGroup;
--
To view, visit http://gerrit.ovirt.org/21579
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iacb121d2e89922b04b8331db92e437cefc8b6b5c
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kobi Ianko <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Kobi Ianko <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
