Roy Golan has posted comments on this change.
Change subject: core, engine: sPAPR SCSI on PPC64 VMs
......................................................................
Patch Set 3: Code-Review-1
(2 comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskInterface.java
Line 5:
Line 6: public enum DiskInterface {
Line 7:
Line 8: IDE("ide", "ide"),
Line 9: VirtIO_SCSI("virtio-scsi", "scsi"),
Allon - shouldn't this name draws a db upgrade script? isn't this outdates all
OVF in our export domains? and requires proper import handling?f
Line 10: VirtIO("virtio", "virtio"),
Line 11: SPAPR_VSCSI("spapr-vscsi", "scsi");
Line 12:
Line 13: private String name;
Line 10: VirtIO("virtio", "virtio"),
Line 11: SPAPR_VSCSI("spapr-vscsi", "scsi");
Line 12:
Line 13: private String name;
Line 14: private String interfaceName;
Allon - the name attribute is simply redundant. if the name is unique, the best
thing to do is use the enum member name should it?
then the enum would simplify to
prite DiskInterface(String interfaceName)
also the forValue() is a waste.
Line 15: private static Map<String, DiskInterface> mappings;
Line 16:
Line 17: static {
Line 18: mappings = new HashMap<String, DiskInterface>();
--
To view, visit http://gerrit.ovirt.org/18622
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id4fefa225cb44f0e09a7a056e07b8393dda6819b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
<[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Leonardo Bianconi <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Vitor de Lima <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
