Roy Golan has posted comments on this change.
Change subject: core: Added arch support for VM and Template
......................................................................
Patch Set 10:
(3 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVMClusterCommand.java
Line 91: return
failCanDoAction(VdcBllMessages.VIRTIO_SCSI_INTERFACE_IS_NOT_AVAILABLE_FOR_CLUSTER_LEVEL);
Line 92: }
Line 93:
Line 94: if
(StringUtils.isNotEmpty(targetCluster.getcpu_name())) {
Line 95: if
(!targetCluster.getArchitecture().equals(vm.getClusterArch())) {
use !=
Line 96: return
failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_VM_CLUSTER_DIFFERENT_ARCHITECTURES);
Line 97: }
Line 98: }
Line 99: else {
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java
Line 212: }
Line 213:
Line 214: // check if the selected template is compatible with Cluster
architecture.
Line 215: if
(!getVmTemplate().getId().equals(VmTemplateHandler.BlankVmTemplateId)
Line 216: &&
!getVdsGroup().getArchitecture().equals(getVmTemplate().getClusterArch())) {
use !=
Line 217: return
failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_TEMPLATE_IS_INCOMPATIBLE);
Line 218: }
Line 219:
Line 220: if (getStoragePool() == null || getStoragePool().getStatus()
!= StoragePoolStatus.Up) {
Line 216: &&
!getVdsGroup().getArchitecture().equals(getVmTemplate().getClusterArch())) {
Line 217: return
failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_TEMPLATE_IS_INCOMPATIBLE);
Line 218: }
Line 219:
Line 220: if (getStoragePool() == null || getStoragePool().getStatus()
!= StoragePoolStatus.Up) {
is this related?
Line 221: return
failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_IMAGE_REPOSITORY_NOT_FOUND);
Line 222: }
Line 223:
Line 224: if (!verifyAddVM()) {
--
To view, visit http://gerrit.ovirt.org/18227
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia877dd2d13525de6693883e43d0ca786f77f9310
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Leonardo Bianconi <[email protected]>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
<[email protected]>
Gerrit-Reviewer: Leonardo Bianconi <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vitor de Lima <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
